From d5dc38b0710b3995df8898b046e7df5761764951 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 17:55:00 +0200 Subject: [PATCH 1/6] chore(provisioner/terraform): minimize testdata diff It was hard to deduce whether or not changes in our terraform testdata are relevant or not, so we now have a rudimentary filter for randomly generated values that aren't relevant for the testdata. --- .../calling-module/calling-module.tfplan.json | 5 ++ .../calling-module.tfstate.json | 2 + .../chaining-resources.tfplan.json | 5 ++ .../chaining-resources.tfstate.json | 2 + .../conflicting-resources.tfplan.json | 5 ++ .../conflicting-resources.tfstate.json | 2 + .../display-apps-disabled.tfplan.json | 5 ++ .../display-apps-disabled.tfstate.json | 2 + .../display-apps/display-apps.tfplan.json | 5 ++ .../display-apps/display-apps.tfstate.json | 2 + .../external-auth-providers.tfplan.json | 5 ++ .../external-auth-providers.tfstate.json | 2 + provisioner/terraform/testdata/generate.sh | 46 +++++++++++++++++++ .../instance-id/instance-id.tfplan.json | 5 ++ .../instance-id/instance-id.tfstate.json | 2 + .../mapped-apps/mapped-apps.tfplan.json | 5 ++ .../mapped-apps/mapped-apps.tfstate.json | 2 + .../multiple-agents-multiple-apps.tfplan.json | 10 ++++ ...multiple-agents-multiple-apps.tfstate.json | 4 ++ .../multiple-agents-multiple-envs.tfplan.json | 10 ++++ ...multiple-agents-multiple-envs.tfstate.json | 4 ++ ...ltiple-agents-multiple-scripts.tfplan.json | 10 ++++ ...tiple-agents-multiple-scripts.tfstate.json | 4 ++ .../multiple-agents.tfplan.json | 20 ++++++++ .../multiple-agents.tfstate.json | 8 ++++ .../multiple-apps/multiple-apps.tfplan.json | 5 ++ .../multiple-apps/multiple-apps.tfstate.json | 2 + .../resource-metadata-duplicate.tfplan.json | 5 ++ .../resource-metadata-duplicate.tfstate.json | 2 + .../resource-metadata.tfplan.json | 5 ++ .../resource-metadata.tfstate.json | 2 + .../rich-parameters-order.tfplan.json | 5 ++ .../rich-parameters-order.tfstate.json | 2 + .../rich-parameters-validation.tfplan.json | 5 ++ .../rich-parameters-validation.tfstate.json | 2 + .../rich-parameters.tfplan.json | 5 ++ .../rich-parameters.tfstate.json | 2 + provisioner/terraform/testdata/version.txt | 2 +- 38 files changed, 215 insertions(+), 1 deletion(-) diff --git a/provisioner/terraform/testdata/calling-module/calling-module.tfplan.json b/provisioner/terraform/testdata/calling-module/calling-module.tfplan.json index a8d5b951cb85e..e2a0f20b1c625 100644 --- a/provisioner/terraform/testdata/calling-module/calling-module.tfplan.json +++ b/provisioner/terraform/testdata/calling-module/calling-module.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -91,6 +93,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -101,12 +104,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/calling-module/calling-module.tfstate.json b/provisioner/terraform/testdata/calling-module/calling-module.tfstate.json index ca645c25065bc..5baaf2ab4b978 100644 --- a/provisioner/terraform/testdata/calling-module/calling-module.tfstate.json +++ b/provisioner/terraform/testdata/calling-module/calling-module.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfplan.json b/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfplan.json index 91cf0e5bb43db..01e47405a6384 100644 --- a/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfplan.json +++ b/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -81,6 +83,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -91,12 +94,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfstate.json b/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfstate.json index 6c5211f4fcaeb..8f25b435f2e68 100644 --- a/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfstate.json +++ b/provisioner/terraform/testdata/chaining-resources/chaining-resources.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfplan.json b/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfplan.json index 85cdf029354e1..7018070facce2 100644 --- a/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfplan.json +++ b/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -81,6 +83,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -91,12 +94,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfstate.json b/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfstate.json index 1a44f1c2ba60b..3e633ac135573 100644 --- a/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfstate.json +++ b/provisioner/terraform/testdata/conflicting-resources/conflicting-resources.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfplan.json b/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfplan.json index 7c34c4a241349..523a3bacf3d12 100644 --- a/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfplan.json +++ b/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfplan.json @@ -30,6 +30,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -40,6 +41,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -89,6 +91,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -101,6 +104,7 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, @@ -109,6 +113,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfstate.json b/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfstate.json index 7698800efe61e..504bb3502be55 100644 --- a/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfstate.json +++ b/provisioner/terraform/testdata/display-apps-disabled/display-apps-disabled.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/display-apps/display-apps.tfplan.json b/provisioner/terraform/testdata/display-apps/display-apps.tfplan.json index f2b5f5f8172de..bb1694171c575 100644 --- a/provisioner/terraform/testdata/display-apps/display-apps.tfplan.json +++ b/provisioner/terraform/testdata/display-apps/display-apps.tfplan.json @@ -30,6 +30,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -40,6 +41,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -89,6 +91,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -101,6 +104,7 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, @@ -109,6 +113,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/display-apps/display-apps.tfstate.json b/provisioner/terraform/testdata/display-apps/display-apps.tfstate.json index fd54371e20d47..eaf46fbc1e9c5 100644 --- a/provisioner/terraform/testdata/display-apps/display-apps.tfstate.json +++ b/provisioner/terraform/testdata/display-apps/display-apps.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfplan.json b/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfplan.json index 4e32609c10c97..3ba31efd64be6 100644 --- a/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfplan.json +++ b/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -69,6 +71,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -79,12 +82,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfstate.json b/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfstate.json index 93a4845752e93..95d61e1c9dd13 100644 --- a/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfstate.json +++ b/provisioner/terraform/testdata/external-auth-providers/external-auth-providers.tfstate.json @@ -60,6 +60,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -71,6 +72,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/generate.sh b/provisioner/terraform/testdata/generate.sh index 72b090dc6b749..7bec3ed4e3947 100755 --- a/provisioner/terraform/testdata/generate.sh +++ b/provisioner/terraform/testdata/generate.sh @@ -23,6 +23,43 @@ generate() { fi } +minimize_diff() { + for f in *.tf*.json; do + declare -A deleted=() + declare -a sed_args=() + while read -r line; do + # Deleted line (previous value). + if [[ $line = -\ * ]]; then + key="${line#*\"}" + key="${key%%\"*}" + value="${line#*: }" + value="${value#*\"}" + value="${value%\"*}" + declare deleted["$key"]="$value" + # Added line (new value). + elif [[ $line = +\ * ]]; then + key="${line#*\"}" + key="${key%%\"*}" + value="${line#*: }" + value="${value#*\"}" + value="${value%\"*}" + # Matched key, restore the value. + if [[ -v deleted["$key"] ]]; then + sed_args+=(-e "s|${value}|${deleted["$key"]}|g") + unset deleted["$key"] + fi + fi + if [[ ${#sed_args[@]} -gt 0 ]]; then + sed -i '' "${sed_args[@]}" "$f" + fi + done < <( + # Filter out known keys with autogenerated values. + git diff -- "$f" | + grep -E "\"(terraform_version|id|agent_id|resource_id|token|random|timestamp)\":" + ) + done +} + run() { d="$1" cd "$d" @@ -51,6 +88,10 @@ run() { echo "== Error generating test data for: $name" return 1 fi + if ((minimize)); then + echo "== Minimizing diffs for: $name" + minimize_diff + fi echo "== Done generating test data for: $name" exit 0 } @@ -60,6 +101,11 @@ if [[ " $* " == *" --help "* || " $* " == *" -h "* ]]; then exit 0 fi +minimize=1 +if [[ " $* " == *" --no-minimize "* ]]; then + minimize=0 +fi + declare -a jobs=() if [[ $# -gt 0 ]]; then for d in "$@"; do diff --git a/provisioner/terraform/testdata/instance-id/instance-id.tfplan.json b/provisioner/terraform/testdata/instance-id/instance-id.tfplan.json index 1b3e8170c853e..be2b976ca73da 100644 --- a/provisioner/terraform/testdata/instance-id/instance-id.tfplan.json +++ b/provisioner/terraform/testdata/instance-id/instance-id.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -81,6 +83,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -91,12 +94,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/instance-id/instance-id.tfstate.json b/provisioner/terraform/testdata/instance-id/instance-id.tfstate.json index 6d582d900d0b8..710eb6ff542da 100644 --- a/provisioner/terraform/testdata/instance-id/instance-id.tfstate.json +++ b/provisioner/terraform/testdata/instance-id/instance-id.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfplan.json b/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfplan.json index 7cf56ed33584a..1eb9888c034d4 100644 --- a/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfplan.json +++ b/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -121,6 +123,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -131,12 +134,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfstate.json b/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfstate.json index 8b1d71e9e735c..67609142a56fb 100644 --- a/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfstate.json +++ b/provisioner/terraform/testdata/mapped-apps/mapped-apps.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfplan.json b/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfplan.json index fcf17ccf62eb8..db9a8ef88e7de 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfplan.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -49,6 +51,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -57,6 +60,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -192,6 +196,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -202,12 +207,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -233,6 +240,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -243,12 +251,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfstate.json b/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfstate.json index 27946bc039991..e6b495afd49bd 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfstate.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-apps/multiple-agents-multiple-apps.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -74,6 +76,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -85,6 +88,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfplan.json b/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfplan.json index 69dec4b3edea4..199d4de0124aa 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfplan.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -49,6 +51,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -57,6 +60,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -148,6 +152,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -158,12 +163,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -189,6 +196,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -199,12 +207,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfstate.json b/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfstate.json index 0d22cdfd0730a..98c4b91e3fd49 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfstate.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-envs/multiple-agents-multiple-envs.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -74,6 +76,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -85,6 +88,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfplan.json b/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfplan.json index a67e892754196..1c0141a88c14c 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfplan.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -49,6 +51,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -57,6 +60,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -169,6 +173,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -179,12 +184,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -210,6 +217,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -220,12 +228,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfstate.json b/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfstate.json index 183f5060c7dcb..8a885bb5a0735 100644 --- a/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfstate.json +++ b/provisioner/terraform/testdata/multiple-agents-multiple-scripts/multiple-agents-multiple-scripts.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -74,6 +76,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -85,6 +88,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfplan.json b/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfplan.json index 65639d5554e63..309442fcc4be2 100644 --- a/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfplan.json +++ b/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -49,6 +51,7 @@ "motd_file": "/etc/motd", "order": null, "os": "darwin", + "resources_monitoring": [], "shutdown_script": "echo bye bye", "startup_script": null, "startup_script_behavior": "non-blocking", @@ -57,6 +60,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -77,6 +81,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "blocking", @@ -85,6 +90,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -105,6 +111,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -113,6 +120,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -153,6 +161,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -163,12 +172,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -194,6 +205,7 @@ "motd_file": "/etc/motd", "order": null, "os": "darwin", + "resources_monitoring": [], "shutdown_script": "echo bye bye", "startup_script": null, "startup_script_behavior": "non-blocking", @@ -204,12 +216,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -235,6 +249,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "blocking", @@ -245,12 +260,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } @@ -276,6 +293,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -286,12 +304,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfstate.json b/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfstate.json index 4a4820d82eb06..a6a098a53ec37 100644 --- a/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfstate.json +++ b/provisioner/terraform/testdata/multiple-agents/multiple-agents.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -74,6 +76,7 @@ "motd_file": "/etc/motd", "order": null, "os": "darwin", + "resources_monitoring": [], "shutdown_script": "echo bye bye", "startup_script": null, "startup_script_behavior": "non-blocking", @@ -85,6 +88,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -116,6 +120,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "blocking", @@ -127,6 +132,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -158,6 +164,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -169,6 +176,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfplan.json b/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfplan.json index 92046bb193b57..171999b1226ba 100644 --- a/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfplan.json +++ b/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -152,6 +154,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -162,12 +165,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfstate.json b/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfstate.json index f482a40372afb..1240248b6669e 100644 --- a/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfstate.json +++ b/provisioner/terraform/testdata/multiple-apps/multiple-apps.tfstate.json @@ -32,6 +32,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -43,6 +44,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfplan.json b/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfplan.json index 9e8a1b9d8c241..b8fcf0625741b 100644 --- a/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfplan.json +++ b/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfplan.json @@ -30,6 +30,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -40,6 +41,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } }, @@ -145,6 +147,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -157,6 +160,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true }, "before_sensitive": false, @@ -165,6 +169,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfstate.json b/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfstate.json index 30c3c4e8bc2dd..96a1bb0410222 100644 --- a/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfstate.json +++ b/provisioner/terraform/testdata/resource-metadata-duplicate/resource-metadata-duplicate.tfstate.json @@ -41,6 +41,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -54,6 +55,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfplan.json b/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfplan.json index 33d9f7209d281..ff44c490a39bf 100644 --- a/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfplan.json +++ b/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfplan.json @@ -30,6 +30,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -40,6 +41,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } }, @@ -132,6 +134,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -144,6 +147,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true }, "before_sensitive": false, @@ -152,6 +156,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfstate.json b/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfstate.json index 25345b5a496dc..a690f36133fd1 100644 --- a/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfstate.json +++ b/provisioner/terraform/testdata/resource-metadata/resource-metadata.tfstate.json @@ -41,6 +41,7 @@ "motd_file": null, "order": null, "os": "linux", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -54,6 +55,7 @@ "metadata": [ {} ], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfplan.json b/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfplan.json index 07145608e1b00..4c6e99ed4bba5 100644 --- a/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfplan.json +++ b/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -69,6 +71,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -79,12 +82,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfstate.json b/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfstate.json index ca4715e3cc75b..f54a97b9b0f76 100644 --- a/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfstate.json +++ b/provisioner/terraform/testdata/rich-parameters-order/rich-parameters-order.tfstate.json @@ -86,6 +86,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -97,6 +98,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfplan.json b/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfplan.json index bedba54b2c61a..28e0219b4568a 100644 --- a/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfplan.json +++ b/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -69,6 +71,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -79,12 +82,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfstate.json b/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfstate.json index 365f900773fc2..592c62fcfd6e2 100644 --- a/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfstate.json +++ b/provisioner/terraform/testdata/rich-parameters-validation/rich-parameters-validation.tfstate.json @@ -254,6 +254,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -265,6 +266,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfplan.json b/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfplan.json index 165fa007bfe8a..677af8a4d5cb4 100644 --- a/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfplan.json +++ b/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfplan.json @@ -21,6 +21,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -29,6 +30,7 @@ "sensitive_values": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } }, @@ -69,6 +71,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -79,12 +82,14 @@ "id": true, "init_script": true, "metadata": [], + "resources_monitoring": [], "token": true }, "before_sensitive": false, "after_sensitive": { "display_apps": [], "metadata": [], + "resources_monitoring": [], "token": true } } diff --git a/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfstate.json b/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfstate.json index 4a8a5f45c70ec..c84310be0e773 100644 --- a/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfstate.json +++ b/provisioner/terraform/testdata/rich-parameters/rich-parameters.tfstate.json @@ -247,6 +247,7 @@ "motd_file": null, "order": null, "os": "windows", + "resources_monitoring": [], "shutdown_script": null, "startup_script": null, "startup_script_behavior": "non-blocking", @@ -258,6 +259,7 @@ {} ], "metadata": [], + "resources_monitoring": [], "token": true } }, diff --git a/provisioner/terraform/testdata/version.txt b/provisioner/terraform/testdata/version.txt index 1cac385c6cb86..720c7384c6195 100644 --- a/provisioner/terraform/testdata/version.txt +++ b/provisioner/terraform/testdata/version.txt @@ -1 +1 @@ -1.11.0 +1.11.1 From fea7f9e79bc741fe513d6f7391b4019c8dae4311 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 18:04:34 +0200 Subject: [PATCH 2/6] compat --- provisioner/terraform/testdata/generate.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/provisioner/terraform/testdata/generate.sh b/provisioner/terraform/testdata/generate.sh index 7bec3ed4e3947..4a620c9a92759 100755 --- a/provisioner/terraform/testdata/generate.sh +++ b/provisioner/terraform/testdata/generate.sh @@ -50,7 +50,12 @@ minimize_diff() { fi fi if [[ ${#sed_args[@]} -gt 0 ]]; then - sed -i '' "${sed_args[@]}" "$f" + # Handle macOS compat. + if sed -h 2>&1 | grep -q "\[-i extension\]"; then + sed -i '' "${sed_args[@]}" "$f" + else + sed -i'' "${sed_args[@]}" "$f" + fi fi done < <( # Filter out known keys with autogenerated values. From 801dc0aeb1063f161b4c7adbecc55827824bc0ea Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 18:22:03 +0200 Subject: [PATCH 3/6] fix macos again --- provisioner/terraform/testdata/generate.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provisioner/terraform/testdata/generate.sh b/provisioner/terraform/testdata/generate.sh index 4a620c9a92759..cc3ce48baf9b4 100755 --- a/provisioner/terraform/testdata/generate.sh +++ b/provisioner/terraform/testdata/generate.sh @@ -51,7 +51,7 @@ minimize_diff() { fi if [[ ${#sed_args[@]} -gt 0 ]]; then # Handle macOS compat. - if sed -h 2>&1 | grep -q "\[-i extension\]"; then + if grep -q -- "\[-i extension\]" < <(sed -h 2>&1); then sed -i '' "${sed_args[@]}" "$f" else sed -i'' "${sed_args[@]}" "$f" From 53ed840016adf08578e4727c9ffeab8d415830e9 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 18:30:10 +0200 Subject: [PATCH 4/6] shellcheck --- provisioner/terraform/testdata/generate.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/provisioner/terraform/testdata/generate.sh b/provisioner/terraform/testdata/generate.sh index cc3ce48baf9b4..bc5aca797e1f0 100755 --- a/provisioner/terraform/testdata/generate.sh +++ b/provisioner/terraform/testdata/generate.sh @@ -45,8 +45,8 @@ minimize_diff() { value="${value%\"*}" # Matched key, restore the value. if [[ -v deleted["$key"] ]]; then - sed_args+=(-e "s|${value}|${deleted["$key"]}|g") - unset deleted["$key"] + sed_args+=(-e "s|${value}|${deleted["$key"]}|") + unset "deleted[$key]" fi fi if [[ ${#sed_args[@]} -gt 0 ]]; then From c43470153a797320c19a74eff319f7580c1d728c Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 18:30:59 +0200 Subject: [PATCH 5/6] undo version.txt --- provisioner/terraform/testdata/version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provisioner/terraform/testdata/version.txt b/provisioner/terraform/testdata/version.txt index 720c7384c6195..1cac385c6cb86 100644 --- a/provisioner/terraform/testdata/version.txt +++ b/provisioner/terraform/testdata/version.txt @@ -1 +1 @@ -1.11.1 +1.11.0 From 6048118b57f6c5faf69a20622d771159fb5fb2b0 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 13 Mar 2025 18:32:09 +0200 Subject: [PATCH 6/6] safer replace via quoted values --- provisioner/terraform/testdata/generate.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/provisioner/terraform/testdata/generate.sh b/provisioner/terraform/testdata/generate.sh index bc5aca797e1f0..1b77c195f8056 100755 --- a/provisioner/terraform/testdata/generate.sh +++ b/provisioner/terraform/testdata/generate.sh @@ -34,7 +34,7 @@ minimize_diff() { key="${key%%\"*}" value="${line#*: }" value="${value#*\"}" - value="${value%\"*}" + value="\"${value%\"*}\"" declare deleted["$key"]="$value" # Added line (new value). elif [[ $line = +\ * ]]; then @@ -42,7 +42,7 @@ minimize_diff() { key="${key%%\"*}" value="${line#*: }" value="${value#*\"}" - value="${value%\"*}" + value="\"${value%\"*}\"" # Matched key, restore the value. if [[ -v deleted["$key"] ]]; then sed_args+=(-e "s|${value}|${deleted["$key"]}|")