-
Notifications
You must be signed in to change notification settings - Fork 875
docs: add AWS AMI upgrade instructions #16973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a small note for those who just used the AWS AMI for their initial installation.
docs/install/upgrade.md
Outdated
The script will unpack the new `coder` binary version over the one currently | ||
installed. | ||
|
||
1. If you're running Coder as a system service, you can restart it with `systemctl`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's the AWS AMI I believe they will definitely be running as a system service and should carry out this step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 awesome - thanks! reworded in 9c05640
@@ -50,3 +72,5 @@ from Winget. | |||
```pwsh | |||
winget install Coder.Coder | |||
``` | |||
|
|||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was an accident to add since this is just Markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction for AWS AMI, GCP VM apply generally whenever Coder is installed via Install script on any systemd supported distro.
I don't feel very positive on if we should add a dedicated tab for AWS AMI case and should handle it more generally.
The issue I was trying to solve in my original PR is that my first experience with coder was with the AWS AMI. Almost immediately after booting I got a notice to update to a newer version, and the instructions to do so didn't specify how to update if you were using the AMI. I wasn't sure if the AMI was created using the Install.sh method so I didn't know the proper path to update. |
@matifali I get what you're saying, but I think we should side with easier findability here. I think we have enough people using the AMI (or will be soon) that we want to answer the question they're asking in an obvious way. Say if they search "update coder aws ami," (like @d1str0 probably did) they'll find a heading that looks like their answer rather than deciding whether or not our documented generic answer fits their issue |
followup to @d1str0's #16937
This PR rearranges the Upgrade doc to use tabs for each section + adds AWS AMI
preview