feat(cli): add open app <workspace> <app-slug> command #17032
Merged
+431
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70e04ba to
a778d6c
Compare
a778d6c to
afbe048
Compare
johnstcn
commented
Mar 21, 2025
| @@ -54,3 +62,107 @@ func Test_resolveAgentAbsPath(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func Test_buildAppLinkURL(t *testing.T) { | |||
There was a problem hiding this comment.
review: I adapted the test cases from app.test.ts. If you have other suggestions for test cases, I'd be happy to add them!
| u.RawQuery = q.Encode() | ||
| // encodeURIComponent replaces spaces with %20 but url.QueryEscape replaces them with +. | ||
| // We replace them with %20 to match the TypeScript implementation. | ||
| u.RawQuery = strings.ReplaceAll(u.RawQuery, "+", "%20") |
There was a problem hiding this comment.
review: I'm not sure if this is strictly necessary? Did it for completeness' sake.
mafredri
reviewed
Mar 21, 2025
mafredri
approved these changes
Mar 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17009
Adds a CLI command
coder open app <workspace> <app-slug>that allows opening arbitrarycoder_appsvia the CLI.Users can optionally specify a preferred region for workspace applications.