Skip to content

feat(cli): start workspace in no-wait mode #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

feat(cli): start workspace in no-wait mode #17087

merged 2 commits into from
Mar 25, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 25, 2025

Fixes: #16408

This PR adds a new flag --no-wait to coder start so that user does not have to observe the provisioner job running.

@mtojek mtojek self-assigned this Mar 25, 2025
@mtojek mtojek requested a review from johnstcn March 25, 2025 12:13
@mtojek mtojek marked this pull request as ready for review March 25, 2025 12:42
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a weak preference for --wait=no, but not enough to block on this.

@mtojek
Copy link
Member Author

mtojek commented Mar 25, 2025

It depends what is your background - Azure CLI uses --no-wait.

@mtojek mtojek merged commit 56082f3 into main Mar 25, 2025
34 checks passed
@mtojek mtojek deleted the 16408-no-wait branch March 25, 2025 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow async workspace start from cli
2 participants