fix(dogfood/coder): add shutdown script and graceful agent shutdown #17110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By stopping Docker, we can hopefully avoid errors like this: ``` 2025-03-26 12:14:53.280+02:00 Error: Error deleting container aa313fca0f72e59d4571afec898392e0ae34567d56c0ad15554c87394d2ca1e1: Error response from daemon: container aa313fca0f72e59d4571afec898392e0ae34567d56c0ad15554c87394d2ca1e1: driver "overlay2" failed to remove root filesystem: unlinkat /var/data/docker/overlay2/2e8e509237c79ebec972cccae9867f3bd6f71d49d4ed68db1b5ba229c3a2ff62/diff/var/lib/docker/overlay2/9c7c4ab0187ece1ca270d146090a8e852808996279d103cb394b2821c472af4c/diff/usr/lib/python3/dist-packages/ansible_collections: directory not empty ```
matifali
approved these changes
Mar 26, 2025
| @@ -418,6 +426,10 @@ resource "docker_container" "workspace" { | |||
| # CPU limits are unnecessary since Docker will load balance automatically | |||
| memory = data.coder_workspace_owner.me.name == "code-asher" ? 65536 : 32768 | |||
| runtime = "sysbox-runc" | |||
| # Ensure the workspace is given time to execute shutdown scripts. | |||
| destroy_grace_seconds = 60 | |||
| stop_timeout = 60 | |||
There was a problem hiding this comment.
Does this make sense as we actually do not stop the container but destroy it.
There was a problem hiding this comment.
I believe when a container is destroyed, it is first stopped. See motivation here #6174 which explains why we're setting both destroy_grace_seconds and stop_timeout.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By stopping Docker, we can hopefully avoid errors like this: