Skip to content

fix: fix permissions for workspace creation #17241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 3, 2025
Merged

fix: fix permissions for workspace creation #17241

merged 7 commits into from
Apr 3, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Apr 3, 2025 •
edited
Loading

This fixes the permissions check when creating a workspace by setting the owner_id to the current user's id. This was originally setting owner_id to *

		createWorkspace: {
			object: {
				resource_type: "workspace",
				organization_id: organizationId,
				owner_id: userId,
			},
			action: "create",
		},

@jaaydenh jaaydenh requested a review from Emyrk April 3, 2025 13:24
@jaaydenh jaaydenh force-pushed the jaaydenh/workspace-creation-fix branch from d226e87 to 19fcd6f Compare April 3, 2025 13:31
Emyrk
Emyrk requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the original issue?

@jaaydenh jaaydenh force-pushed the jaaydenh/workspace-creation-fix branch from 9bdd56a to 49951a6 Compare April 3, 2025 14:11
Emyrk
Emyrk approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manually test, but this checks out with my reasoning

@jaaydenh jaaydenh force-pushed the jaaydenh/workspace-creation-fix branch from 50998fc to 0b13269 Compare April 3, 2025 14:47
johnstcn
johnstcn approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jaaydenh jaaydenh force-pushed the jaaydenh/workspace-creation-fix branch from 03a81d4 to d1f7eb0 Compare April 3, 2025 15:37
@jaaydenh jaaydenh merged commit ccfe1bd into main Apr 3, 2025
34 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/workspace-creation-fix branch April 3, 2025 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@Emyrk Emyrk Emyrk approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaaydenh @johnstcn @Emyrk