Skip to content

feat: support multiple terminal fonts #17257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 7, 2025
Merged

feat: support multiple terminal fonts #17257

merged 22 commits into from
Apr 7, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 4, 2025

Fixes: #15024

Screenshot 2025-04-04 at 15 40 37 Screenshot 2025-04-04 at 15 41 44

This PR extends user appearance settings to select a predefined Terminal font.

Extra changes:

  • rename GetUserAppearanceSettings (and Update...) to GetUserTerminalFont
  • font included Fira Code.

@mtojek mtojek self-assigned this Apr 4, 2025
@mtojek mtojek changed the title feat: switch terminal fonts feat: support multiple terminal fonts Apr 4, 2025
@mtojek mtojek marked this pull request as ready for review April 4, 2025 13:57
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! FE looks good.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! Just some minor suggestions but no need to re-review.

@mtojek mtojek merged commit 743d308 into main Apr 7, 2025
37 of 39 checks passed
@mtojek mtojek deleted the 15024-fira-code branch April 7, 2025 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nerd font to web terminal
3 participants