Skip to content

feat: vpn uses WorkspaceHostnameSuffix for DNS names #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat: vpn uses WorkspaceHostnameSuffix for DNS names #17335

merged 1 commit into from
Apr 11, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 10, 2025 •
edited
Loading

Use the hostname suffix to set DNS names as programmed into the DNS service and returned by the vpn Tunnel.

part of: #16828

@spikecurtis spikecurtis mentioned this pull request Apr 10, 2025
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Apr 10, 2025
Merged
@spikecurtis spikecurtis marked this pull request as ready for review April 10, 2025 13:34
@spikecurtis spikecurtis force-pushed the spike/host-suffix/agent-connection-info branch from 6cee450 to 76cb7a7 Compare April 11, 2025 08:55
@spikecurtis spikecurtis force-pushed the spike/host-suffix/vpn-dns branch from 23bedfa to 1917ec0 Compare April 11, 2025 08:55
@spikecurtis spikecurtis changed the base branch from spike/host-suffix/agent-connection-info to graphite-base/17335 April 11, 2025 09:09
@spikecurtis spikecurtis force-pushed the graphite-base/17335 branch from 76cb7a7 to 12dc086 Compare April 11, 2025 09:10
@spikecurtis spikecurtis force-pushed the spike/host-suffix/vpn-dns branch from 1917ec0 to 377e9ee Compare April 11, 2025 09:10
@graphite-app graphite-app bot changed the base branch from graphite-base/17335 to main April 11, 2025 09:10
@spikecurtis spikecurtis force-pushed the spike/host-suffix/vpn-dns branch from 377e9ee to a1d5db7 Compare April 11, 2025 09:10
@spikecurtis spikecurtis merged commit 2c573dc into main Apr 11, 2025
34 of 35 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 11, 5:24 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/vpn-dns branch April 11, 2025 09:24
@spikecurtis spikecurtis mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @ethanndickson