Skip to content

feat: add configurable DNS match domain for tailnet connections #17336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat: add configurable DNS match domain for tailnet connections #17336

merged 1 commit into from
Apr 11, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 10, 2025 •
edited
Loading

Use the hostname suffix to set the DNS match domain when creating a Tailnet as part of the vpn Tunnel.

part of: #16828

This was referenced Apr 10, 2025
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Apr 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis marked this pull request as ready for review April 10, 2025 13:35
@spikecurtis spikecurtis changed the title feat: VPN sets DNS match domain using Hostname Suffix feat: add configurable DNS match domain for tailnet connections Apr 10, 2025
ethanndickson
ethanndickson approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

image 
$ ping6 works.ethan
PING6(56=40+8+8 bytes) fd60:627a:a42b:4af6:9545:c735:a1be:1cf7 --> fd60:627a:a42b:4491:849c:f1e5:7ac5:eb1f
16 bytes from fd60:627a:a42b:4491:849c:f1e5:7ac5:eb1f, icmp_seq=0 hlim=64 time=18.538 ms

@spikecurtis spikecurtis force-pushed the spike/host-suffix/dns-match-domain branch from 4011a78 to 2c9815a Compare April 11, 2025 08:55
@spikecurtis spikecurtis force-pushed the spike/host-suffix/vpn-dns branch 3 times, most recently from 377e9ee to a1d5db7 Compare April 11, 2025 09:10
@spikecurtis spikecurtis force-pushed the spike/host-suffix/dns-match-domain branch from 2c9815a to 07c5734 Compare April 11, 2025 09:10
@spikecurtis spikecurtis changed the base branch from spike/host-suffix/vpn-dns to graphite-base/17336 April 11, 2025 09:24
@spikecurtis spikecurtis force-pushed the graphite-base/17336 branch from a1d5db7 to 2c573dc Compare April 11, 2025 09:24
@spikecurtis spikecurtis force-pushed the spike/host-suffix/dns-match-domain branch from 07c5734 to e2a4394 Compare April 11, 2025 09:24
@graphite-app graphite-app bot changed the base branch from graphite-base/17336 to main April 11, 2025 09:25
@spikecurtis spikecurtis force-pushed the spike/host-suffix/dns-match-domain branch from e2a4394 to f5d2c41 Compare April 11, 2025 09:25
@spikecurtis spikecurtis force-pushed the spike/host-suffix/dns-match-domain branch from f5d2c41 to a66f016 Compare April 11, 2025 10:47
@spikecurtis spikecurtis merged commit 9e2af3e into main Apr 11, 2025
35 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Apr 11, 7:00 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/host-suffix/dns-match-domain branch April 11, 2025 11:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @ethanndickson