Skip to content

chore: fill out workspace owner data for dynamic parameters #17366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 17, 2025
Merged

chore: fill out workspace owner data for dynamic parameters #17366

merged 10 commits into from
Apr 17, 2025
+635 −345

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Apr 11, 2025 •
edited
Loading

aslilac
aslilac commented Apr 11, 2025
View reviewed changes
@aslilac aslilac changed the base branch from main to lilac/testutil-chan April 15, 2025 21:59
@aslilac aslilac force-pushed the lilac/parameters-owner branch from 8f3f1a1 to 1820c3d Compare April 15, 2025 22:19
@aslilac aslilac requested a review from Emyrk April 16, 2025 15:34
Base automatically changed from lilac/testutil-chan to main April 16, 2025 16:37
Emyrk
Emyrk reviewed Apr 17, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fixup the roles fetched.

And ideally, maybe in another PR, we should refactor the fetching code to be the same implementation as used in the provisioner

@aslilac aslilac requested a review from Emyrk April 17, 2025 19:59
@aslilac aslilac merged commit 2cc56ab into main Apr 17, 2025
38 of 39 checks passed
@aslilac aslilac deleted the lilac/parameters-owner branch April 17, 2025 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parameters: provide user data to evaluator
2 participants
@aslilac @Emyrk