Skip to content

chore: remove nullable list elements in ts typegen #17369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

chore: remove nullable list elements in ts typegen #17369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: remove nullable list elements in ts typegen 
Backend will not send partially null slices.
  • Loading branch information
@Emyrk
Emyrk committed Apr 11, 2025
commit 77db62546933ea9ae97024ecab1ce46a61067cd9
2 changes: 2 additions & 0 deletions scripts/apitypings/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ func TsMutations(ts *guts.Typescript) {
// Omitempty + null is just '?' in golang json marshal
// number?: number | null --> number?: number
config.SimplifyOmitEmpty,
// TsType: (string | null)[] --> (string)[]
config.NullUnionSlices,
)
}

Expand Down
10 changes: 5 additions & 5 deletions site/src/api/typesGenerated.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading