From 77db62546933ea9ae97024ecab1ce46a61067cd9 Mon Sep 17 00:00:00 2001
From: Steven Masley <stevenmasley@gmail.com>
Date: Fri, 11 Apr 2025 15:31:03 -0500
Subject: [PATCH] chore: remove nullable list elements in ts typegen

Backend will not send partially null slices.
---
 scripts/apitypings/main.go     |  2 ++
 site/src/api/typesGenerated.ts | 10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/scripts/apitypings/main.go b/scripts/apitypings/main.go
index 3fd25948162dd..d12d33808e59b 100644
--- a/scripts/apitypings/main.go
+++ b/scripts/apitypings/main.go
@@ -79,6 +79,8 @@ func TsMutations(ts *guts.Typescript) {
 		// Omitempty + null is just '?' in golang json marshal
 		// number?: number | null --> number?: number
 		config.SimplifyOmitEmpty,
+		// TsType: (string | null)[] --> (string)[]
+		config.NullUnionSlices,
 	)
 }
 
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
index 7a443c750de91..3f3d8f92c27e5 100644
--- a/site/src/api/typesGenerated.ts
+++ b/site/src/api/typesGenerated.ts
@@ -569,7 +569,7 @@ export interface DERPRegionReport {
 	readonly warnings: readonly HealthMessage[];
 	readonly error?: string;
 	readonly region: TailDERPRegion | null;
-	readonly node_reports: readonly (DERPNodeReport | null)[];
+	readonly node_reports: readonly DERPNodeReport[];
 }
 
 // From codersdk/deployment.go
@@ -1707,7 +1707,7 @@ export interface PresetParameter {
 export type PreviewDiagnosticSeverityString = string;
 
 // From types/diagnostics.go
-export type PreviewDiagnostics = readonly (FriendlyDiagnostic | null)[];
+export type PreviewDiagnostics = readonly FriendlyDiagnostic[];
 
 // From types/parameter.go
 export interface PreviewParameter extends PreviewParameterData {
@@ -1728,8 +1728,8 @@ export interface PreviewParameterData {
 	readonly mutable: boolean;
 	readonly default_value: NullHCLString;
 	readonly icon: string;
-	readonly options: readonly (PreviewParameterOption | null)[];
-	readonly validations: readonly (PreviewParameterValidation | null)[];
+	readonly options: readonly PreviewParameterOption[];
+	readonly validations: readonly PreviewParameterValidation[];
 	readonly required: boolean;
 	readonly order: number;
 	readonly ephemeral: boolean;
@@ -2463,7 +2463,7 @@ export interface TailDERPRegion {
 	readonly RegionCode: string;
 	readonly RegionName: string;
 	readonly Avoid?: boolean;
-	readonly Nodes: readonly (TailDERPNode | null)[];
+	readonly Nodes: readonly TailDERPNode[];
 }
 
 // From codersdk/deployment.go