Skip to content

test: ignore context.Canceled in acquireWithCancel #17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 17, 2025

fixes coder/internal#584

Ignore canceled error when sending an acquired job, since dRPC is racy and will sometimes return this error even after successfully sending the job, if the test is quickly finished.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested a review from johnstcn April 17, 2025 10:54
@spikecurtis spikecurtis marked this pull request as ready for review April 17, 2025 10:54
@spikecurtis spikecurtis merged commit b3aba6d into main Apr 17, 2025
41 checks passed
@spikecurtis spikecurtis deleted the spike/internal-584 branch April 17, 2025 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestProvisionerd/MaliciousTar
2 participants