Skip to content

feat: add opt-out option to new parameters form #17456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 21, 2025
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Apr 17, 2025

@aslilac aslilac changed the title feat: add new parameters form opt-out feat: add opt-out option to new parameters form Apr 18, 2025
@aslilac aslilac requested a review from jaaydenh April 18, 2025 19:23
@aslilac aslilac marked this pull request as ready for review April 18, 2025 19:24
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Nit: the only thing I would change is the name of NewFormContext to ExperimentalFormContext

@aslilac
Copy link
Member Author

aslilac commented Apr 21, 2025

yeah, you're definitely right 😅 "new" was a weird choice when we already have a name we're using in various places

@aslilac aslilac merged commit f6364a2 into main Apr 21, 2025
34 checks passed
@aslilac aslilac deleted the lilac/parameters-opt-out branch April 21, 2025 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add escape hatch in UI to opt-out of Parameters experiment
2 participants