From 473db06c79e9363cc8184f6c1d82a50e6aa80cc5 Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Thu, 17 Apr 2025 19:53:15 +0000 Subject: [PATCH 1/2] fix: state issues with dynamic parameters --- .../CreateWorkspacePage/CreateWorkspacePageExperimental.tsx | 2 +- .../CreateWorkspacePageViewExperimental.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx index 27d76a23a83cd..178fd4bb442fb 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx @@ -86,7 +86,7 @@ const CreateWorkspacePageExperimental: FC = () => { if (prev?.id === response.id) { return prev; } - return response; + return structuredClone(response); }); }, []); diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 3674884c1fb37..1e0fbbf2281ff 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -117,8 +117,8 @@ export const CreateWorkspacePageViewExperimental: FC< rich_parameter_values: useValidationSchemaForDynamicParameters(parameters), }), - enableReinitialize: true, - validateOnChange: false, + enableReinitialize: false, + validateOnChange: true, validateOnBlur: true, onSubmit: (request) => { if (!hasAllRequiredExternalAuth) { From ab6c88ec321d3d731330cd619b217b3f45f922ed Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Thu, 17 Apr 2025 20:08:35 +0000 Subject: [PATCH 2/2] fix: remove structuredClone --- .../CreateWorkspacePage/CreateWorkspacePageExperimental.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx index 178fd4bb442fb..27d76a23a83cd 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx @@ -86,7 +86,7 @@ const CreateWorkspacePageExperimental: FC = () => { if (prev?.id === response.id) { return prev; } - return structuredClone(response); + return response; }); }, []);