-
Notifications
You must be signed in to change notification settings - Fork 875
feat: reinitialize agents when a prebuilt workspace is claimed #17475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SasSwart
wants to merge
28
commits into
main
Choose a base branch
from
jjs/prebuilds-agent-reinit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,806
−435
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c09c9b9
WIP: agent reinitialization
SasSwart 476fe71
fix assignment to nil map
SasSwart 8c8bca6
fix: ensure prebuilt workspace agent tokens are reused when a prebuil…
SasSwart 7ce4eea
test agent reinitialization
SasSwart 52ac64e
remove defunct metric
SasSwart 362db7c
Remove todo
SasSwart dcc7379
test that we trigger workspace agent reinitialization under the right…
SasSwart ff66b3f
slight improvements to a test
SasSwart efff5d9
review notes to improve legibility
SasSwart cebd5db
add an integration test for prebuilt workspace agent reinitialization
SasSwart 2679138
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-agent-r…
SasSwart 9feebef
enable the premium license in a prebuilds integration test
SasSwart b117b5c
encapsulate WaitForReinitLoop for easier testing
SasSwart a22b414
introduce unit testable abstraction layers
SasSwart 9bbd2c7
test workspace claim pubsub
SasSwart 5804201
add tests for agent reinitialization
SasSwart 7e8dcee
review notes
SasSwart 725f97b
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-agent-r…
SasSwart a9b1567
make fmt lint
SasSwart 21ee970
remove go mod replace
SasSwart e54d7e7
remove defunct logging
SasSwart 2799858
update dependency on terraform-provider-coder
SasSwart 1d93003
update dependency on terraform-provider-coder
SasSwart 763fc12
go mod tidy
SasSwart 0f879c7
make -B gen
SasSwart 61784c9
dont require ids to InsertPresetParameters
SasSwart 604eb27
dont require ids to InsertPresetParameters
SasSwart bf4d2cf
fix: set the running agent token
dannykopping File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
make fmt lint
- Loading branch information
commit a9b156715bc499ac76a9c4eb26746bcfbb6dfac9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warn seems alarmist; lots of legit reasons to shut down. Also, it's unexpected to include more than one call to
slog.Error