Skip to content

chore: loosen static validation when using dynamic parameters #17516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

chore: loosen static validation when using dynamic parameters #17516

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c717b
chore: loosen static validation when using dynamic parameters
aslilac Apr 22, 2025
c9fc648
chore: require the experiment enabled as well
Emyrk Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: require the experiment enabled as well
  • Loading branch information
@Emyrk
Emyrk committed Apr 23, 2025
commit c9fc648d87c2ada8154830fdf304b83eaf1176c4
2 changes: 1 addition & 1 deletion coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ func createWorkspace(
if req.TemplateVersionID != uuid.Nil {
builder = builder.VersionID(req.TemplateVersionID)
}
if req.EnableDynamicParameters {
if req.EnableDynamicParameters && api.Experiments.Enabled(codersdk.ExperimentDynamicParameters) {
builder = builder.UsingDynamicParameters()
}

Expand Down
Loading