Skip to content

fix: fix workspace creation on template page #17518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Apr 22, 2025

Closes #17470

You can't use names in permission checks; they always expect IDs. The permission check on this page was using a name, resulting in the backend not always answering the question correctly.

@aslilac aslilac requested a review from jaaydenh April 22, 2025 23:00
@aslilac aslilac changed the title fix: fix "create workspace" button on template page fix: fix workspace creation on template page Apr 22, 2025
@aslilac aslilac merged commit 3b4343d into main Apr 23, 2025
42 checks passed
@aslilac aslilac deleted the lilac/fix-create-workspace-button branch April 23, 2025 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: org admin cannot "create workspace" button on the template page but can on other pages
2 participants