fix: add websocket close handling #17548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
commented
Apr 23, 2025
| @@ -107,6 +108,15 @@ const CreateWorkspacePageExperimental: FC = () => { | |||
| onError: (error) => { | |||
| setWsError(error); | |||
| }, | |||
| onClose: () => { | |||
There was a problem hiding this comment.
The assumption is that if the websocket closes while the component is mounted, that this is unexpected and we should inform the user with an error in the UI
aslilac
approved these changes
Apr 23, 2025
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17508
Display an error in the UI that the websocket closed if the user is still interacting with the dynamic parameters form