chore: mark parameters as required #17551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaydenh
commented
Apr 23, 2025
| @@ -95,8 +95,12 @@ const ParameterLabel: FC<ParameterLabelProps> = ({ parameter, isPreset }) => { | |||
|
|
|||
| <div className="flex flex-col w-full gap-1"> | |||
| <Label className="flex gap-2 flex-wrap text-sm font-medium"> | |||
| {displayName} | |||
|
|
|||
| <span className="flex"> | |||
There was a problem hiding this comment.
For now, I decided to add the required asterisk for all parameters even though it really doesn't make sense for (checkbox, slider, radio, switch) since all parameters have the required prop.
aslilac
approved these changes
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a red asterisk next to a parameter name if it is required and marks passes the parameter required value to input and textarea form controls.
The multi-select combobox needs additional work (in a separate PR) so that it can handle the required prop correctly for form submit.