From 644795c58874c9ee06c7ec52ab316a9b2e8fe8f8 Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden.halko@gmail.com>
Date: Wed, 23 Apr 2025 22:54:32 +0000
Subject: [PATCH 1/2] chore: mark parameters as required

---
 .../DynamicParameter/DynamicParameter.tsx     | 31 ++++++++++++-------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
index c09317094a33c..269226d9e4d23 100644
--- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
+++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -95,8 +95,12 @@ const ParameterLabel: FC<ParameterLabelProps> = ({ parameter, isPreset }) => {
 
 			<div className="flex flex-col w-full gap-1">
 				<Label className="flex gap-2 flex-wrap text-sm font-medium">
-					{displayName}
-
+					<span className="flex">
+						{displayName}
+						{!parameter.required && (
+							<span className="text-content-destructive">*</span>
+						)}
+					</span>
 					{parameter.mutable && (
 						<TooltipProvider delayDuration={100}>
 							<Tooltip>
@@ -169,6 +173,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					onValueChange={onChange}
 					defaultValue={defaultValue}
 					disabled={disabled}
+					required={parameter.required}
 				>
 					<SelectTrigger>
 						<SelectValue
@@ -325,6 +330,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					placeholder={
 						(parameter.styling as { placeholder?: string })?.placeholder
 					}
+					required={parameter.required}
 				/>
 			);
 
@@ -346,16 +352,17 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			}
 
 			return (
-				<Input
-					type={inputType}
-					defaultValue={defaultValue}
-					onChange={(e) => onChange(e.target.value)}
-					disabled={disabled}
-					placeholder={
-						(parameter.styling as { placeholder?: string })?.placeholder
-					}
-					{...inputProps}
-				/>
+					<Input
+						type={inputType}
+						defaultValue={defaultValue}
+						onChange={(e) => onChange(e.target.value)}
+						disabled={disabled}
+						required={parameter.required}
+						placeholder={
+							(parameter.styling as { placeholder?: string })?.placeholder
+						}
+						{...inputProps}
+					/>
 			);
 		}
 	}

From 8c7d3a976a39e7ab81e8bb431280de801e5fdb38 Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden.halko@gmail.com>
Date: Wed, 23 Apr 2025 23:03:19 +0000
Subject: [PATCH 2/2] fix: fix format

---
 .../DynamicParameter/DynamicParameter.tsx     | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
index 269226d9e4d23..d93933228be92 100644
--- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
+++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -352,17 +352,17 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			}
 
 			return (
-					<Input
-						type={inputType}
-						defaultValue={defaultValue}
-						onChange={(e) => onChange(e.target.value)}
-						disabled={disabled}
-						required={parameter.required}
-						placeholder={
-							(parameter.styling as { placeholder?: string })?.placeholder
-						}
-						{...inputProps}
-					/>
+				<Input
+					type={inputType}
+					defaultValue={defaultValue}
+					onChange={(e) => onChange(e.target.value)}
+					disabled={disabled}
+					required={parameter.required}
+					placeholder={
+						(parameter.styling as { placeholder?: string })?.placeholder
+					}
+					{...inputProps}
+				/>
 			);
 		}
 	}