feat: add tag and value in validation error details #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Emyrk Would this change impact our frontend behavior? Like here: https://github.com/coder/coder/blob/main/site/src/api/errors.ts#L41 |
|
New behavior is as follows: |
AbhineetJain
commented
May 26, 2022
| @@ -58,7 +58,7 @@ func TestRead(t *testing.T) { | |||
|
|
|||
| var validate toValidate | |||
| require.True(t, httpapi.Read(rw, r, &validate)) | |||
| require.Equal(t, validate.Value, "hi") | |||
| require.Equal(t, "hi", validate.Value) | |||
There was a problem hiding this comment.
The expected and actual arguments were inverted so I changed them to what they should be.
Yes it affects the FE, but I think it is still a positive change. Even for the FE |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* add tag and value in validation error details * fix unit tests and linter * add quotes around value * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a more details to validation errors from the API.
Subtasks
Fixes #1757