diff --git a/coderd/httpapi/httpapi.go b/coderd/httpapi/httpapi.go index afdb4685ed063..385c88020e161 100644 --- a/coderd/httpapi/httpapi.go +++ b/coderd/httpapi/httpapi.go @@ -104,7 +104,7 @@ func Read(rw http.ResponseWriter, r *http.Request, value interface{}) bool { for _, validationError := range validationErrors { apiErrors = append(apiErrors, Error{ Field: validationError.Field(), - Detail: validationError.Tag(), + Detail: fmt.Sprintf("Validation failed for tag %q with value: \"%v\"", validationError.Tag(), validationError.Value()), }) } Write(rw, http.StatusBadRequest, Response{ diff --git a/coderd/httpapi/httpapi_test.go b/coderd/httpapi/httpapi_test.go index ad251747aa604..20f7af5c08ab1 100644 --- a/coderd/httpapi/httpapi_test.go +++ b/coderd/httpapi/httpapi_test.go @@ -58,7 +58,7 @@ func TestRead(t *testing.T) { var validate toValidate require.True(t, httpapi.Read(rw, r, &validate)) - require.Equal(t, validate.Value, "hi") + require.Equal(t, "hi", validate.Value) }) t.Run("ValidateFailure", func(t *testing.T) { @@ -75,8 +75,8 @@ func TestRead(t *testing.T) { err := json.NewDecoder(rw.Body).Decode(&v) require.NoError(t, err) require.Len(t, v.Errors, 1) - require.Equal(t, v.Errors[0].Field, "value") - require.Equal(t, v.Errors[0].Detail, "required") + require.Equal(t, "value", v.Errors[0].Field) + require.Equal(t, "Validation failed for tag \"required\" with value: \"\"", v.Errors[0].Detail) }) } @@ -140,7 +140,7 @@ func TestReadUsername(t *testing.T) { r := httptest.NewRequest("POST", "/", bytes.NewBuffer(data)) var validate toValidate - require.Equal(t, httpapi.Read(rw, r, &validate), testCase.Valid) + require.Equal(t, testCase.Valid, httpapi.Read(rw, r, &validate)) }) } }