From 002e782f5a18bc48e44cc508158fbff572528ab6 Mon Sep 17 00:00:00 2001 From: Ethan Dickson Date: Wed, 30 Apr 2025 05:03:58 +0000 Subject: [PATCH] test: avoid sharing `echo.Responses` across tests --- cli/restart_test.go | 2 +- cli/start_test.go | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/cli/restart_test.go b/cli/restart_test.go index 2179aea74497e..d69344435bf28 100644 --- a/cli/restart_test.go +++ b/cli/restart_test.go @@ -359,7 +359,7 @@ func TestRestartWithParameters(t *testing.T) { client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) owner := coderdtest.CreateFirstUser(t, client) member, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID) - version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, mutableParamsResponse) + version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, mutableParamsResponse()) coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID) workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) { diff --git a/cli/start_test.go b/cli/start_test.go index 2e893bc20f5c4..29fa4cdb46e5f 100644 --- a/cli/start_test.go +++ b/cli/start_test.go @@ -33,8 +33,8 @@ const ( mutableParameterValue = "hello" ) -var ( - mutableParamsResponse = &echo.Responses{ +func mutableParamsResponse() *echo.Responses { + return &echo.Responses{ Parse: echo.ParseComplete, ProvisionPlan: []*proto.Response{ { @@ -54,8 +54,10 @@ var ( }, ProvisionApply: echo.ApplyComplete, } +} - immutableParamsResponse = &echo.Responses{ +func immutableParamsResponse() *echo.Responses { + return &echo.Responses{ Parse: echo.ParseComplete, ProvisionPlan: []*proto.Response{ { @@ -74,7 +76,7 @@ var ( }, ProvisionApply: echo.ApplyComplete, } -) +} func TestStart(t *testing.T) { t.Parallel() @@ -210,7 +212,7 @@ func TestStartWithParameters(t *testing.T) { client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) owner := coderdtest.CreateFirstUser(t, client) member, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID) - version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, immutableParamsResponse) + version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, immutableParamsResponse()) coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID) workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) { @@ -262,7 +264,7 @@ func TestStartWithParameters(t *testing.T) { client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) owner := coderdtest.CreateFirstUser(t, client) member, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID) - version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, mutableParamsResponse) + version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, mutableParamsResponse()) coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID) workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) {