Skip to content

fix: update devcontainer data every 10s #17619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Apr 30, 2025

Fix coder/internal#594

Notice:
This is a temporary solution to get the devcontainers feature released. Maybe a better solution, to avoid pulling the API every 10 seconds, is to implement a websocket connection to get updates on containers.

@BrunoQuaresma BrunoQuaresma requested a review from mafredri April 30, 2025 14:09
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 30, 2025
@BrunoQuaresma BrunoQuaresma added the hotfix PRs only. Harmless small change. Only humans may set this. label Apr 30, 2025
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderfully simple fix! ❤️

@BrunoQuaresma BrunoQuaresma merged commit ff54ae3 into main Apr 30, 2025
40 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/pull-devcontainers branch April 30, 2025 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ui: workspace view does not automatically update when devcontainer starts
2 participants