Skip to content

feat: delete API token in /logout API #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 27, 2022
Merged

feat: delete API token in /logout API #1770

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5c062df
delete API token in logout api
AbhineetJain May 26, 2022
77880f1
add deleteapikeybyid to databasefake
AbhineetJain May 26, 2022
994a294
delete api key in logout inline
AbhineetJain May 26, 2022
094498a
set blank cookie on logout always
AbhineetJain May 26, 2022
eb12bee
refactor logout flow, add unit tests
AbhineetJain May 26, 2022
8bb5713
update logout messsage
AbhineetJain May 26, 2022
fd56d39
use read-only file mode for windows
AbhineetJain May 26, 2022
492db6a
fix file mode on windows for cleanup
AbhineetJain May 26, 2022
5fa278d
Merge branch 'main' into abhineetjain/delete-session-token-api
AbhineetJain May 26, 2022
2ad0fbc
change file permissions on windows
AbhineetJain May 27, 2022
fd9231d
Merge branch 'main' into abhineetjain/delete-session-token-api
AbhineetJain May 27, 2022
a49b16f
Merge branch 'main' into abhineetjain/delete-session-token-api
AbhineetJain May 27, 2022
9a3731d
assert error is not nil
AbhineetJain May 27, 2022
c38a0f5
refactor cli
AbhineetJain May 27, 2022
a19e092
try different file mode on windows
AbhineetJain May 27, 2022
c82c661
try different file mode on windows
AbhineetJain May 27, 2022
a76d136
Merge branch 'main' into abhineetjain/delete-session-token-api
AbhineetJain May 27, 2022
84ec351
try keeping the files open on Windows
AbhineetJain May 27, 2022
6707efa
fix the error message on Windows
AbhineetJain May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor cli
  • Loading branch information
@AbhineetJain
AbhineetJain committed May 27, 2022
commit c38a0f50be23b368c3b70f203d53947015fe7d3a
25 changes: 12 additions & 13 deletions cli/logout_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,18 @@ func TestLogout(t *testing.T) {
err = os.Chmod(string(config), 0500)
require.NoError(t, err)
}
t.Cleanup(func() {
// Setting the permissions back for cleanup.
if runtime.GOOS == "windows" {
err = os.Chmod(string(config.URL()), 0600)
require.NoError(t, err)
err = os.Chmod(string(config.Session()), 0600)
require.NoError(t, err)
} else {
err = os.Chmod(string(config), 0700)
require.NoError(t, err)
}
})

logoutChan := make(chan struct{})
logout, _ := clitest.New(t, "logout", "--global-config", string(config))
Expand All @@ -164,19 +176,6 @@ func TestLogout(t *testing.T) {
pty.ExpectMatch("Are you sure you want to logout?")
pty.WriteLine("yes")
<-logoutChan

t.Cleanup(func() {
// Setting the permissions back for cleanup.
if runtime.GOOS == "windows" {
err = os.Chmod(string(config.URL()), 0600)
require.NoError(t, err)
err = os.Chmod(string(config.Session()), 0600)
require.NoError(t, err)
} else {
err = os.Chmod(string(config), 0700)
require.NoError(t, err)
}
})
})
}

Expand Down