Skip to content

chore: improve variable names of mocked users #17701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Many times I got confused when using MockUser and MockUser2 so I just decided to better naming them to MockUserOwner and MockUserMember.

@BrunoQuaresma BrunoQuaresma requested a review from a team May 7, 2025 12:42
@BrunoQuaresma BrunoQuaresma self-assigned this May 7, 2025
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot, a team and aslilac and removed request for a team and Kira-Pilot May 7, 2025 12:42
@BrunoQuaresma BrunoQuaresma changed the title chore: better represent user mocks chore: improve representation of user mocks May 7, 2025
@BrunoQuaresma BrunoQuaresma changed the title chore: improve representation of user mocks chore: improve user mock names May 7, 2025
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the pr title? it made me think you had changed the name properties (like MockUser.name)

maybe something like "improve variable names of mocked users"

@BrunoQuaresma BrunoQuaresma changed the title chore: improve user mock names chore: improve variable names of mocked users May 8, 2025
@BrunoQuaresma BrunoQuaresma merged commit 2695f4e into main May 8, 2025
37 of 38 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/chore-mocks branch May 8, 2025 12:32
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants