Skip to content

feat: load terraform modules when using dynamic parameters #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented May 7, 2025

No description provided.

@aslilac aslilac changed the base branch from main to lilac/persist-terraform-modules May 7, 2025 22:48
@aslilac

This comment was marked as outdated.

Base automatically changed from lilac/persist-terraform-modules to main May 8, 2025 22:13
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we noticed a bug with directories, will re-approve

@aslilac aslilac marked this pull request as ready for review May 13, 2025 20:11
@aslilac aslilac force-pushed the lilac/load-terraform-modules branch from db752ea to 8c6fd63 Compare May 13, 2025 20:36
Comment on lines -56 to +63
require.Equal(t, "05d2994c1a50ce573fe2c2b29507e5131ba004d15812d8bb0a46dc732f3211f5", hash)
require.Equal(t, "edcccdd4db68869552542e66bad87a51e2e455a358964912805a32b06123cb5c", hash)
} else {
require.Equal(t, "c219943913051e4637527cd03ae2b7303f6945005a262cdd420f9c2af490d572", hash)
require.Equal(t, "67027a27452d60ce2799fcfd70329c185f9aee7115b0944e3aa00b4776be9d92", hash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍. We need consistent hashes to reuse the same modules files on the backend

@Emyrk Emyrk merged commit 60762d4 into main May 13, 2025
34 checks passed
@Emyrk Emyrk deleted the lilac/load-terraform-modules branch May 13, 2025 21:07
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants