Skip to content

chore: replace MUI icons with Lucide icons - 5 #17750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Replacements:

MUI | Lucide
OpenInNewOutlined | ExternalLinkIcon
HelpOutline | CircleHelpIcon
ErrorOutline | CircleAlertIcon

@BrunoQuaresma BrunoQuaresma self-assigned this May 9, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just ignore this file for now 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im just curious what you discovered about using a .md file for instead of making this directly part of a prompt?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is just easier to reuse and write the prompt.

@BrunoQuaresma BrunoQuaresma requested review from a team and jaaydenh and removed request for a team May 9, 2025 19:09
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming you don't commit the migrate-icons.md file.

It is interesting that most of these changes don't appear as storybook. Seems like there is quite a bit of gap with storybook in the codebase.

@BrunoQuaresma BrunoQuaresma changed the title chore: replace MUI icons - 5 chore: replace MUI icons with Lucide icons - 5 May 12, 2025
@BrunoQuaresma BrunoQuaresma merged commit 15bd7a3 into main May 12, 2025
35 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/replace-mui-5 branch May 12, 2025 16:36
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants