feat: include read/write byte stats in scaletests JSON report #17777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mafredri requested a review as you opened the original issue, please lmk if I've misunderstood |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
236ce51 to
8b3fc67
Compare
bcpeinhardt
approved these changes
Jun 13, 2025
| } | ||
|
|
||
| // Run implements Runnable. | ||
| func (fns testFns) Run(ctx context.Context, id string, logs io.Writer) error { | ||
| return fns.RunFn(ctx, id, logs) | ||
| } | ||
|
|
||
| // GetBytesTransferred implements Collectable. | ||
| func (fns testFns) GetBytesTransferred() (bytesRead int64, bytesWritten int64) { |
There was a problem hiding this comment.
I'm curious what's going on with this pattern, but your addition seems totally in line with what's already here :)
There was a problem hiding this comment.
yeah I don't particularly like it, feels odd/reads strangely, but it's already in use for the cleanable interface as well so 🤷
Signed-off-by: Callum Styan <callumstyan@gmail.com>
bcpeinhardt
approved these changes
Jun 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #12157
WIP/Draft as I spend some time to confirm my understanding of the current code and the changes from @joobisb original PR here, ATM this PR is just his commits as I want to check what CI jobs were failing.