Skip to content

feat: add experimental workspace parameters page for dynamic params #17841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025
Merged

feat: add experimental workspace parameters page for dynamic params #17841

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dd83a00
feat: add experimental workspace parameters page for dynamic params
jaaydenh May 14, 2025
f19178c
fix: update type
jaaydenh May 15, 2025
0c7f4c1
chore: get parity with create workspace page
jaaydenh May 19, 2025
17a2c85
fix: pass form value to dynamic parameter
jaaydenh May 20, 2025
93359a0
chore: move useSyncFormParameters to shared hook
jaaydenh May 20, 2025
82e0b07
chore: use Map to improve performance
jaaydenh May 21, 2025
e827b2c
chore: move hook inside modules
jaaydenh May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: pass form value to dynamic parameter
  • Loading branch information
@jaaydenh
jaaydenh committed May 20, 2025
commit 17a2c8581353cf2d06ccb55b0a5d745dfe5cc79c
6 changes: 6 additions & 0 deletions ...WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ export const WorkspaceParametersPageViewExperimental: FC<
}
autofill={false}
disabled={isDisabled}
value={
form.values?.rich_parameter_values?.[index]?.value || ""
}
/>
);
})}
Expand Down Expand Up @@ -190,6 +193,9 @@ export const WorkspaceParametersPageViewExperimental: FC<
}
autofill={false}
disabled={isDisabled}
value={
form.values?.rich_parameter_values?.[index]?.value || ""
}
/>
);
})}
Expand Down
Loading