Skip to content

docs: rename external-auth heading in setup doc #17868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented May 15, 2025

to help point searchers to the correct doc

preview

@EdwardAngert EdwardAngert requested a review from stirby May 15, 2025 21:26
@EdwardAngert EdwardAngert self-assigned this May 15, 2025
@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label May 15, 2025
@stirby
Copy link
Collaborator

stirby commented May 19, 2025

What do you think about changing the name of the "external auth" page to the more verbose "external authentication"?

@EdwardAngert
Copy link
Contributor Author

EdwardAngert commented May 19, 2025

apparently there's this too: https://github.com/coder/coder/blob/setup-ext-auth/docs/admin/templates/extending-templates/external-auth.md

edit: but it's not in manifest so it doesn't show up anywhere except github

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edward!

@EdwardAngert EdwardAngert merged commit 1f54c36 into main May 20, 2025
33 checks passed
@EdwardAngert EdwardAngert deleted the setup-ext-auth branch May 20, 2025 19:10
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants