Skip to content

fix: show diagnostics if there are no parameters #17967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

jaaydenh
Copy link
Contributor

Prefer to show the top level diagnostics inside the parameters section for context but this adds a case to show diagnostics if there are no parameters.

Normally, the entire parameters section is hidden if there are no parameters.

@jaaydenh jaaydenh self-assigned this May 21, 2025
@jaaydenh jaaydenh requested a review from Emyrk May 21, 2025 10:35
@jaaydenh jaaydenh merged commit 36d938f into main May 21, 2025
36 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/dynamic-params-diagnostics branch May 21, 2025 14:55
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants