fix: skip TestReinitializeAgent until we can adapt it for windows #17968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
May 21, 2025
| @@ -89,6 +90,12 @@ func TestReinitializeAgent(t *testing.T) { | |||
| t.Skip("dbmem cannot currently claim a workspace") | |||
| } | |||
|
|
|||
| if runtime.GOOS == "windows" { | |||
| t.Skip("test startup script is not supported on windows") | |||
hugodutka
approved these changes
May 21, 2025
|
Can we ship this? This issue is causing CI failure every morning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to coder/internal#642
I've reached a timebox trying to get a script for windows to work, so I'm skipping it for now.