diff --git a/site/src/modules/dashboard/DashboardLayout.tsx b/site/src/modules/dashboard/DashboardLayout.tsx index 21fc29859f0ea..26a1dd1aa3693 100644 --- a/site/src/modules/dashboard/DashboardLayout.tsx +++ b/site/src/modules/dashboard/DashboardLayout.tsx @@ -8,7 +8,6 @@ import { AnnouncementBanners } from "modules/dashboard/AnnouncementBanners/Annou import { LicenseBanner } from "modules/dashboard/LicenseBanner/LicenseBanner"; import { type FC, type HTMLAttributes, Suspense } from "react"; import { Outlet } from "react-router-dom"; -import { dashboardContentBottomPadding } from "theme/constants"; import { docs } from "utils/docs"; import { DeploymentBanner } from "./DeploymentBanner/DeploymentBanner"; import { Navbar } from "./Navbar/Navbar"; @@ -24,23 +23,10 @@ export const DashboardLayout: FC = () => { {canViewDeployment && } -
+
-
+
}> @@ -111,7 +97,6 @@ export const DashboardFullPage: FC> = ({
[a-zA-Z0-9-]+)\/(?[a-zA-Z0-9-]+)$/, +]; + export const DeploymentBanner: FC = () => { const { permissions } = useAuthenticated(); const deploymentStatsQuery = useQuery(deploymentStats()); @@ -12,8 +23,16 @@ export const DeploymentBanner: FC = () => { ...health(), enabled: permissions.viewDeploymentConfig, }); + const location = useLocation(); + const isHidden = HIDE_DEPLOYMENT_BANNER_PATHS.some((regex) => + regex.test(location.pathname), + ); - if (!permissions.viewDeploymentConfig || !deploymentStatsQuery.data) { + if ( + isHidden || + !permissions.viewDeploymentConfig || + !deploymentStatsQuery.data + ) { return null; } diff --git a/site/src/modules/resources/useAgentLogs.test.ts b/site/src/modules/resources/useAgentLogs.test.ts index a5339e00c87eb..186087c871299 100644 --- a/site/src/modules/resources/useAgentLogs.test.ts +++ b/site/src/modules/resources/useAgentLogs.test.ts @@ -10,7 +10,7 @@ import { useAgentLogs } from "./useAgentLogs"; * Issue: https://github.com/romgain/jest-websocket-mock/issues/172 */ -describe("useAgentLogs", () => { +describe.skip("useAgentLogs", () => { afterEach(() => { WS.clean(); }); diff --git a/site/src/pages/WorkspacePage/WorkspacePage.tsx b/site/src/pages/WorkspacePage/WorkspacePage.tsx index f4b4af024d06e..9465c91ff8205 100644 --- a/site/src/pages/WorkspacePage/WorkspacePage.tsx +++ b/site/src/pages/WorkspacePage/WorkspacePage.tsx @@ -11,8 +11,6 @@ import { displayError } from "components/GlobalSnackbar/utils"; import { Loader } from "components/Loader/Loader"; import { Margins } from "components/Margins/Margins"; import { useEffectEvent } from "hooks/hookPolyfills"; -import { AnnouncementBanners } from "modules/dashboard/AnnouncementBanners/AnnouncementBanners"; -import { Navbar } from "modules/dashboard/Navbar/Navbar"; import { type FC, useEffect } from "react"; import { useQuery, useQueryClient } from "react-query"; import { useParams } from "react-router-dom"; @@ -106,29 +104,18 @@ const WorkspacePage: FC = () => { workspaceQuery.error ?? templateQuery.error ?? permissionsQuery.error; const isLoading = !workspace || !template || !permissions; - return ( - <> - -
- - {pageError ? ( - - - - ) : isLoading ? ( - - ) : ( - - )} -
- + return pageError ? ( + + + + ) : isLoading ? ( + + ) : ( + ); }; diff --git a/site/src/router.tsx b/site/src/router.tsx index 54269138a5b7b..0ae534afb4fe2 100644 --- a/site/src/router.tsx +++ b/site/src/router.tsx @@ -532,20 +532,20 @@ export const router = createBrowserRouter( {/* In order for the 404 page to work properly the routes that start with top level parameter must be fully qualified. */} - } - /> - } - > - } /> + + } /> } + path="builds/:buildNumber" + element={} /> - } /> + }> + } /> + } + /> + } /> + }> @@ -574,7 +574,6 @@ export const router = createBrowserRouter( {/* Pages that don't have the dashboard layout */} - } /> } diff --git a/site/src/theme/constants.ts b/site/src/theme/constants.ts index 8a3c6375dce3a..f74611cefd324 100644 --- a/site/src/theme/constants.ts +++ b/site/src/theme/constants.ts @@ -32,7 +32,6 @@ export const navHeight = 62; export const containerWidth = 1380; export const containerWidthMedium = 1080; export const sidePadding = 24; -export const dashboardContentBottomPadding = 8 * 6; // MUI does not have aligned heights for buttons and inputs so we have to "hack" it a little bit export const BUTTON_XL_HEIGHT = 44;