fix: prevent layout shift when Select component dropdown appears #17990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
approved these changes
May 22, 2025
BrunoQuaresma
approved these changes
May 22, 2025
|
@BrunoQuaresma added another commit to handle the case of MUI popovers |
c1c518c to
56d7008
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrollbars are always visible, open the dropdown for a
Selectcomponent causes a layout shift because of scrollbars being hidden when theSelectis open. This fix prevents the layout shift from the scrollbar being removed.Screen.Recording.2025-05-22.at.17.06.37.mov