Skip to content

fix: handle invalid provisioning timings in ui #18058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

fix: handle invalid provisioning timings in ui #18058

merged 1 commit into from
May 27, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 27, 2025 •
edited
Loading

Relates to #15432

  • Adds a storybook entry for zero values in provisioner timings.
  • Coerces a 'zero' start time to an 'instant'.
  • Improves timing chart handling for large timeframes. Previously, this would have caused the tab to run out of memory when encountering a time.Time{}.
  • Render 'instants' as 'invalid' in timing chart.

@johnstcn johnstcn requested review from BrunoQuaresma and mtojek May 27, 2025 13:49
@johnstcn johnstcn self-assigned this May 27, 2025
@johnstcn johnstcn mentioned this pull request May 27, 2025
Closed
@johnstcn johnstcn merged commit ce134bc into main May 27, 2025
37 checks passed
@johnstcn johnstcn deleted the cj/site/timings-handle-invalid branch May 27, 2025 14:10
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @BrunoQuaresma