feat: add filecache prometheus metrics #18089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 29, 2025
Comment on lines
+201
to
+204
| ev, err := entry.value.Load() | ||
| if err == nil { | ||
| c.currentCacheSize.Add(-1 * float64(ev.size)) | ||
| } |
There was a problem hiding this comment.
This feels really unfortunate, but it is all cached so it's not an expensive call.
aslilac
reviewed
May 29, 2025
coderd/files/cache.go
Outdated
| } | ||
|
|
||
| content := bytes.NewBuffer(file.Data) | ||
| return archivefs.FromTarReader(content), nil | ||
| return archivefs.FromTarReader(content), int64(content.Len()), nil |
There was a problem hiding this comment.
hmm. I really dislike trusting honest reporting of size here. is there not some way we could inspect the size of this entire object from inside the cache at runtime? there might not be but it'd be super slick
There was a problem hiding this comment.
I don't think there is without doing some recursive Stat() call on all the files in the filesystem.
Right here is the cheapest place to do it. If we ever add a compression layer, then this won't be 100% accurate, but at present it does indicate the total number of bytes held in memory by the cache entry.
aslilac
approved these changes
May 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic parameters has an in memory file cache. This adds prometheus metrics to monitor said cache.
Closes coder/internal#554