From 96ee1924be1ea8330b618a3a08e9cb381ac4d79f Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Fri, 30 May 2025 17:11:32 +0000 Subject: [PATCH 1/2] fix: check length of form.error object --- .../CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 817a7abfccb09..5891acb4e9126 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -179,7 +179,7 @@ export const CreateWorkspacePageViewExperimental: FC< }, [error]); useEffect(() => { - if (form.submitCount > 0 && form.errors) { + if (form.submitCount > 0 && Object.keys(form.errors).length > 0) { workspaceNameInputRef.current?.scrollIntoView({ behavior: "smooth", block: "center", From 5a70075b62a777a9d0db91f6b0ae0922ef5e1b8a Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Fri, 30 May 2025 17:11:52 +0000 Subject: [PATCH 2/2] fix: only show auth required badge if not authenticated --- site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx b/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx index 5ce8cf4c3db1f..65e2de6dce2be 100644 --- a/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx +++ b/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx @@ -38,8 +38,12 @@ export const ExternalAuthButton: FC = ({ /> )}

{auth.display_name}

- {!auth.optional && ( - + {!auth.authenticated && !auth.optional && ( + Required )}