From 4c51fb53c42e69c0e3e09900ae3682b030f659d5 Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Mon, 2 Jun 2025 16:10:38 +0000 Subject: [PATCH] fix: do not block rendering on parsing error --- .../DynamicParameter/DynamicParameter.tsx | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx index 35c5763c23d25..c3448ac7d7182 100644 --- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx +++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx @@ -387,11 +387,9 @@ const ParameterField: FC = ({ const parsedValues = parseStringArrayValue(value ?? ""); if (parsedValues.error) { - return ( -

- {parsedValues.error} -

- ); + // Diagnostics on parameter already handle this case, do not duplicate error message + // Reset user's values to an empty array. This would overwrite any default values + parsedValues.values = []; } // Map parameter options to MultiSelectCombobox options format @@ -440,11 +438,9 @@ const ParameterField: FC = ({ const parsedValues = parseStringArrayValue(value ?? ""); if (parsedValues.error) { - return ( -

- {parsedValues.error} -

- ); + // Diagnostics on parameter already handle this case, do not duplicate error message + // Reset user's values to an empty array. This would overwrite any default values + parsedValues.values = []; } return (