-
Notifications
You must be signed in to change notification settings - Fork 875
feat: port forwarding dropdown #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a911ed7
to
63da850
Compare
What's the status of this feature? |
This is blocked on being able to actually open a link to a port. I messed up because I thought work on that was underway but it seems actually not to be? I was thinking I could just add it myself but I have not found the time to work on that yet. IDK how we plan on doing the sub-domain version but since we already have |
I have no clue where the other work sits. Perhaps @tjcran can shed some light here. It's unfortunate to watch the ever-increasing merge conflicts erode this code. Dev URLs are a necessary feature for about half of our v1 users that are browser only.
Yeah, the wildcard subdomain setup always sucks. I think we all know the limitations of the path-based solution, but it could be an interesting fallback when the wildcard domain isn't setup yet. If we did that, we would want to make it very clear_ to the user that they could setup a path-less solution. |
@ammario i believe @kylecarbs is doing the work for that. I'll let him comment. |
That work is partially implemented by the #1773 PR. The wildcard subdomain routing and authentication still needs to be added. It's a bit of an awkward UX for our current setup experience, so I think we should align on how we'll do that before continuing. We can replicate the v1 experience, but it wasn't very smooth. |
To clarify, this is fully blocked on me, not @code-asher! |
This should stay open until we make headway on #2986. It'll certainly come into play! |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
What this does:
Todo:
netstat
package does not support darwin. Not sure how to fix this yet.Closes #1624
lame-demo-0006-2022-05-27_12.14.16.mp4