From cb52c2c7f1b1819a0cfe2b252145122d62323165 Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Thu, 5 Jun 2025 18:44:08 +0000 Subject: [PATCH 1/2] fix: show preset parameters when they have diagnostics Always show preset parameters in CreateWorkspacePageViewExperimental if the preset parameter has any diagnostics, regardless of the showPresetParameters toggle state. Fixes #651 --- .../CreateWorkspacePageViewExperimental.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 09056aa66af72..37837d49b6a4b 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -621,7 +621,9 @@ export const CreateWorkspacePageViewExperimental: FC< isPresetParameter; // Hide preset parameters if showPresetParameters is false - if (!showPresetParameters && isPresetParameter) { + // Always show preset parameters if they have any diagnostics + const hasParameterDiagnostics = parameter.diagnostics.length > 0; + if (!showPresetParameters && isPresetParameter && !hasParameterDiagnostics) { return null; } From 334e3ac7e141782a1ca8dfbe675b41cd1536d5bf Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Thu, 5 Jun 2025 20:44:40 +0000 Subject: [PATCH 2/2] chore: cleanup --- .../CreateWorkspacePageViewExperimental.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 37837d49b6a4b..1527e084503d4 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -620,10 +620,12 @@ export const CreateWorkspacePageViewExperimental: FC< creatingWorkspace || isPresetParameter; - // Hide preset parameters if showPresetParameters is false // Always show preset parameters if they have any diagnostics - const hasParameterDiagnostics = parameter.diagnostics.length > 0; - if (!showPresetParameters && isPresetParameter && !hasParameterDiagnostics) { + if ( + !showPresetParameters && + isPresetParameter && + parameter.diagnostics.length === 0 + ) { return null; }