From b68fb6771b07fb624587334f505c116ecce28427 Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Mon, 9 Jun 2025 20:12:11 +0000 Subject: [PATCH 1/2] fix: improve JetBrains error message to mention Toolbox requirement When users try to open JetBrains IDEs (GoLand, IntelliJ, etc.) without having JetBrains Toolbox installed, they now receive a more helpful error message that specifically mentions the Toolbox requirement instead of the generic 'must be installed first' message. Fixes #17786 Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com> --- site/src/modules/apps/useAppLink.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index efaab474e6db9..205f0301f9334 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -50,7 +50,17 @@ export const useAppLink = ( // an error message will be displayed. const openAppExternallyFailedTimeout = 500; const openAppExternallyFailed = setTimeout(() => { - displayError(`${label} must be installed first.`); + // Check if this is a JetBrains IDE app + const isJetBrainsApp = app.url && ( + app.url.startsWith("jetbrains-gateway:") || + app.url.startsWith("jetbrains:") + ); + + if (isJetBrainsApp) { + displayError(`To use ${label}, you need to have JetBrains Toolbox installed.`); + } else { + displayError(`${label} must be installed first.`); + } }, openAppExternallyFailedTimeout); window.addEventListener("blur", () => { clearTimeout(openAppExternallyFailed); From e2367793f07441fcc3f85f933cba4c9f76727186 Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Mon, 9 Jun 2025 20:14:57 +0000 Subject: [PATCH 2/2] fix: apply proper formatting to JetBrains error message code Apply Biome formatter requirements for consistent code style. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com> --- site/src/modules/apps/useAppLink.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index 205f0301f9334..aafd048a7e674 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -51,13 +51,15 @@ export const useAppLink = ( const openAppExternallyFailedTimeout = 500; const openAppExternallyFailed = setTimeout(() => { // Check if this is a JetBrains IDE app - const isJetBrainsApp = app.url && ( - app.url.startsWith("jetbrains-gateway:") || - app.url.startsWith("jetbrains:") - ); - + const isJetBrainsApp = + app.url && + (app.url.startsWith("jetbrains-gateway:") || + app.url.startsWith("jetbrains:")); + if (isJetBrainsApp) { - displayError(`To use ${label}, you need to have JetBrains Toolbox installed.`); + displayError( + `To use ${label}, you need to have JetBrains Toolbox installed.`, + ); } else { displayError(`${label} must be installed first.`); }