From dababb2b4e20e2e9551eea49013dfbfc55c1fdda Mon Sep 17 00:00:00 2001 From: Ethan Dickson Date: Wed, 11 Jun 2025 06:49:18 +0000 Subject: [PATCH] test: ensure the return value of MockAuditor.Contains is checked --- coderd/agentapi/audit_test.go | 4 ++-- coderd/userauth_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/coderd/agentapi/audit_test.go b/coderd/agentapi/audit_test.go index 8b4ae3ea60f77..b881fde5d22bc 100644 --- a/coderd/agentapi/audit_test.go +++ b/coderd/agentapi/audit_test.go @@ -135,7 +135,7 @@ func TestAuditReport(t *testing.T) { }, }) - mAudit.Contains(t, database.AuditLog{ + require.True(t, mAudit.Contains(t, database.AuditLog{ Time: dbtime.Time(tt.time).In(time.UTC), Action: agentProtoConnectionActionToAudit(t, *tt.action), OrganizationID: workspace.OrganizationID, @@ -146,7 +146,7 @@ func TestAuditReport(t *testing.T) { ResourceTarget: agent.Name, Ip: pqtype.Inet{Valid: true, IPNet: net.IPNet{IP: net.ParseIP(tt.ip), Mask: net.CIDRMask(32, 32)}}, StatusCode: tt.status, - }) + })) // Check some additional fields. var m map[string]any diff --git a/coderd/userauth_test.go b/coderd/userauth_test.go index 7f6dcf771ab5d..6d224818a6a46 100644 --- a/coderd/userauth_test.go +++ b/coderd/userauth_test.go @@ -1577,10 +1577,10 @@ func TestUserOIDC(t *testing.T) { }) require.Equal(t, http.StatusOK, resp.StatusCode) - auditor.Contains(t, database.AuditLog{ + require.True(t, auditor.Contains(t, database.AuditLog{ ResourceType: database.ResourceTypeUser, AdditionalFields: json.RawMessage(`{"automatic_actor":"coder","automatic_subsystem":"dormancy"}`), - }) + })) me, err := client.User(ctx, "me") require.NoError(t, err)