fix: use tailscale that avoids small MTU paths #18323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 11, 2025
| // . │ Client 2 ├─────────────────────────────────────┘ | ||
| // . │ │fdac:38fa:ffff:2::1 | ||
| // . └──────────────┘ | ||
| // The veth link between Client 1 and the router has a configurable MTU via Client1MTU. | ||
| func (n TriangleNetwork) SetupNetworking(t *testing.T, l slog.Logger) TestNetworking { |
There was a problem hiding this comment.
It's not really a triangle anymore unfortunately, more of a pitchfork 🤣
There was a problem hiding this comment.
You should redo the diagram to be triforce 🤣
There was a problem hiding this comment.
Not sure unicode has the correct (60°) diagonals
ethanndickson
approved these changes
Jun 11, 2025
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15523
Uses latest https://github.com/coder/tailscale which includes coder/tailscale#85 to stop selecting paths with small MTU for direct connections.
Also updates the tailnet integration test to reproduce the issue. The previous version had the 2 peers connected by a single veth, but this allows the OS to fragment the packet. In the new version, the 2 peers (and server) are all connected by a central router. The link between peer 1 and the router has an adjustable MTU. IPv6 does not allow packets to be fragmented by intermediate routers, so sending a too-large packet in this scenario forces the router to drop packets and reproduce the issue (without the tailscale changes).