From 0d13d2df87495af2e7ccb67427f60905c7e4deaf Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Thu, 19 Jun 2025 07:26:35 +0000 Subject: [PATCH 1/4] feat: improve AppLink error message for coder:// URLs Add specific error message for coder:// URLs that instructs users to install Coder Desktop first. This follows the same pattern as the existing JetBrains error handling. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com> --- site/src/modules/apps/useAppLink.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index aafd048a7e674..aedb4fb2d24f1 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -56,10 +56,18 @@ export const useAppLink = ( (app.url.startsWith("jetbrains-gateway:") || app.url.startsWith("jetbrains:")); + // Check if this is a coder:// URL + const isCoderApp = + app.url && app.url.startsWith("coder://"); + if (isJetBrainsApp) { displayError( `To use ${label}, you need to have JetBrains Toolbox installed.`, ); + } else if (isCoderApp) { + displayError( + `To use ${label} you need Coder Desktop to be installed first.`, + ); } else { displayError(`${label} must be installed first.`); } From da404cdb0e6d2a22696e087e34fe828dc37c2c7f Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Thu, 19 Jun 2025 12:41:43 +0500 Subject: [PATCH 2/4] use similar error message. --- site/src/modules/apps/useAppLink.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index aedb4fb2d24f1..0507e29d732ba 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -66,7 +66,7 @@ export const useAppLink = ( ); } else if (isCoderApp) { displayError( - `To use ${label} you need Coder Desktop to be installed first.`, + `To use ${label} you need to have Coder Desktop installed`, ); } else { displayError(`${label} must be installed first.`); From 7ae0fc303aed34502f6200e84fec1339fa976e13 Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Thu, 19 Jun 2025 15:49:36 +0500 Subject: [PATCH 3/4] make lint/fmt --- site/src/modules/apps/useAppLink.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index 0507e29d732ba..e76457421531d 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -57,8 +57,7 @@ export const useAppLink = ( app.url.startsWith("jetbrains:")); // Check if this is a coder:// URL - const isCoderApp = - app.url && app.url.startsWith("coder://"); + const isCoderApp = app.url?.startsWith("coder://"); if (isJetBrainsApp) { displayError( From 6d25c7e8b48259df512b7d7f8fa1a88a364c4b99 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Fri, 20 Jun 2025 11:58:54 +0500 Subject: [PATCH 4/4] Update site/src/modules/apps/useAppLink.ts Co-authored-by: Dean Sheather --- site/src/modules/apps/useAppLink.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/modules/apps/useAppLink.ts b/site/src/modules/apps/useAppLink.ts index e76457421531d..daad0d493e2c7 100644 --- a/site/src/modules/apps/useAppLink.ts +++ b/site/src/modules/apps/useAppLink.ts @@ -57,7 +57,7 @@ export const useAppLink = ( app.url.startsWith("jetbrains:")); // Check if this is a coder:// URL - const isCoderApp = app.url?.startsWith("coder://"); + const isCoderApp = app.url?.startsWith("coder:"); if (isJetBrainsApp) { displayError(