From 6ca73d43fde3e52c4dbe4fc643cdebf360ad6167 Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Tue, 24 Jun 2025 15:43:49 +0000 Subject: [PATCH] chore: dynamic params visual improvements --- .../workspaces/DynamicParameter/DynamicParameter.tsx | 7 ++++--- .../WorkspaceActions/BuildParametersPopover.tsx | 8 +++----- .../WorkspaceParametersPageViewExperimental.tsx | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx index ec04bd7ea8e09..3680b7f5e88c5 100644 --- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx +++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx @@ -139,7 +139,7 @@ const ParameterLabel: FC = ({ htmlFor={id} className="flex gap-2 flex-wrap text-sm font-medium" > - + {displayName} {parameter.required && ( * @@ -175,7 +175,8 @@ const ParameterLabel: FC = ({ - This parameter only applies for a single workspace start + This parameter is ephemeral and will reset to the template + default on workspace restart. @@ -209,7 +210,7 @@ const ParameterLabel: FC = ({ - Autofilled from the URL + Autofilled from the URL. diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx index 76b100fc96745..f084c4c200b67 100644 --- a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx @@ -114,12 +114,10 @@ const BuildParametersPopoverContent: FC = ({ return (
-

- Ephemeral Parameters -

- This template has ephemeral parameters that must be configured on the - workspace parameters page + This workspace has ephemeral parameters which may use a temporary + value on workspace start. Configure the following parameters in + workspace settings.

diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx index 02f8ea3699653..14253ad51f827 100644 --- a/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx +++ b/site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx @@ -194,7 +194,7 @@ export const WorkspaceParametersPageViewExperimental: FC< {(templateVersionId || workspace.latest_build.template_version_id) && (
-

+

{templateVersionId ?? workspace.latest_build.template_version_id}