Skip to content

feat: use preview to compute workspace tags from terraform #18720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stevenmasley/preview_errors
Choose a base branch
from

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jul 2, 2025

TODO: Need to add unit tests

Copy link
Member Author

Emyrk commented Jul 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Emyrk Emyrk force-pushed the stevenmasley/preview_tags_rebase branch 2 times, most recently from 6c1fdf5 to 20d0254 Compare July 2, 2025 16:10
@Emyrk Emyrk force-pushed the stevenmasley/preview_errors branch from 15a6ca1 to f0dd768 Compare July 2, 2025 16:10
@Emyrk Emyrk force-pushed the stevenmasley/preview_tags_rebase branch 2 times, most recently from 6f3d388 to f4cd152 Compare July 2, 2025 16:46
@Emyrk Emyrk force-pushed the stevenmasley/preview_errors branch from f0dd768 to a87678d Compare July 2, 2025 16:48
@Emyrk Emyrk force-pushed the stevenmasley/preview_tags_rebase branch 2 times, most recently from 29a7cf6 to 4d06a6c Compare July 2, 2025 17:32
"github.com/coder/coder/v2/testutil"
)

func Test_DynamicWorkspaceTagDefaultsFromFile(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is copied from tfparse_test.go.

The tfparse test can be removed when this becomes the new standard.

@Emyrk Emyrk force-pushed the stevenmasley/preview_errors branch from 96c83c7 to 8d594a7 Compare July 2, 2025 21:51
@Emyrk Emyrk force-pushed the stevenmasley/preview_tags_rebase branch 2 times, most recently from ae6d044 to 956f053 Compare July 2, 2025 22:08
@Emyrk Emyrk force-pushed the stevenmasley/preview_tags_rebase branch from 956f053 to 1a6c0b4 Compare July 2, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant