From 0281f94b276d1e8a7a8582fc01d065601c15f167 Mon Sep 17 00:00:00 2001 From: Ethan Dickson Date: Thu, 3 Jul 2025 03:06:31 +0000 Subject: [PATCH 1/2] fix(cli): calculate coder ping max correctly --- cli/ping.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/ping.go b/cli/ping.go index f75ed42d26362..ec094ea1a317b 100644 --- a/cli/ping.go +++ b/cli/ping.go @@ -53,7 +53,7 @@ func (s *pingSummary) addResult(r *ipnstate.PingResult) { if s.Min == nil || r.LatencySeconds < s.Min.Seconds() { s.Min = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second))) } - if s.Max == nil || r.LatencySeconds > s.Min.Seconds() { + if s.Max == nil || r.LatencySeconds > s.Max.Seconds() { s.Max = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second))) } s.latencySum += r.LatencySeconds From e42b2e4180931bcb3d01fe333567c87ddf95ebfb Mon Sep 17 00:00:00 2001 From: Ethan Dickson Date: Thu, 3 Jul 2025 03:10:25 +0000 Subject: [PATCH 2/2] test --- cli/ping_internal_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/ping_internal_test.go b/cli/ping_internal_test.go index 0c131fadfa52a..5448d29f32133 100644 --- a/cli/ping_internal_test.go +++ b/cli/ping_internal_test.go @@ -21,11 +21,11 @@ func TestBuildSummary(t *testing.T) { }, { Err: "", - LatencySeconds: 0.2, + LatencySeconds: 0.3, }, { Err: "", - LatencySeconds: 0.3, + LatencySeconds: 0.2, }, { Err: "ping error",