feat(coderd): add support for external agents to API's and provisioner #19286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 11, 2025
b641ffe to
07a9c42
Compare
johnstcn
approved these changes
Aug 12, 2025
c012284 to
63fefbb
Compare
60cccc2 to
0cf5381
Compare
| t.Run("OK Linux", func(t *testing.T) { | ||
| t.Parallel() | ||
| client := coderdtest.New(t, nil) | ||
| script, err := client.InitScript(context.Background(), "linux", "amd64") |
There was a problem hiding this comment.
Probably should make one of these arm64 for variety, and also assert that the string /bin/coder-OS-ARCH[.exe] shows up
63fefbb to
6033188
Compare
4e94ed6 to
5a0bf15
Compare
| @@ -223,6 +223,7 @@ func Workspaces(ctx context.Context, db database.Store, query string, page coder | |||
| Valid: values.Has("outdated"), | |||
| } | |||
| filter.HasAITask = parser.NullableBoolean(values, sql.NullBool{}, "has-ai-task") | |||
There was a problem hiding this comment.
Can you also file a ticket to fix has-ai-task?
| Message: "Workspace does not have an external agent.", | ||
| }) | ||
| return | ||
| } |
There was a problem hiding this comment.
This is good but I still think the specific agent should be checked as well.
coderd/coderd.go
Outdated
| @@ -180,6 +180,8 @@ type Options struct { | |||
| // Entitlements can come from the enterprise caller if enterprise code is | |||
| // included. | |||
| Entitlements *entitlements.Set | |||
| // HasLicense indicates if a license is installed. | |||
There was a problem hiding this comment.
This should just be a field on entitlements.Set if possible.
6033188 to
9e885fe
Compare
5a0bf15 to
ed93d09
Compare
enterprise/coderd/workspaceagents.go
Outdated
|
|
||
| found := false | ||
| for _, resource := range resources { | ||
| if resource.Type == "coder_external_agent" && resource.Name == agentName { |
There was a problem hiding this comment.
Wouldn't it be better to see if the agent's parent resource ID is a coder_external_agent?
…rm resource references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.
Depends on: coder/terraform-provider-coder#424